reduce duplication and remove unnecessary code#102
Open
VictorAugDB wants to merge 1 commit intotalyssonoc:mainfrom
Open
reduce duplication and remove unnecessary code#102VictorAugDB wants to merge 1 commit intotalyssonoc:mainfrom
VictorAugDB wants to merge 1 commit intotalyssonoc:mainfrom
Conversation
VictorAugDB
changed the title
Create an interface to repeatable type and use destructuring with deafult value to remove unnecessary code
wenderjean
reviewed
May 23, 2022
| import { Application, HookFn, makeApp } from '@/_lib/Application'; | ||
|
|
||
| type EntrypointFn<T extends Record<string | symbol, any>> = (arg: Context<T>) => Promise<void>; | ||
| type RecordAny<T extends string | symbol = string | symbol> = Record<T, any> |
There was a problem hiding this comment.
Just for curiosity but this is a kind of thing we should place as a shared type? cc/ @talyssonoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create an interface to repeatable type and use destructuring with deafult value to remove unnecessary code